SparseLU: remove dead/buggy in-loop row-permutation determinant update libeigen/eigen!2447 Co-authored-by: Rasmus Munk Larsen <rmlarsen@gmail.com>
diff --git a/Eigen/src/SparseLU/SparseLU.h b/Eigen/src/SparseLU/SparseLU.h index 124becc..c9fcaa0 100644 --- a/Eigen/src/SparseLU/SparseLU.h +++ b/Eigen/src/SparseLU/SparseLU.h
@@ -777,11 +777,6 @@ return; } - // Update the determinant of the row permutation matrix - // FIXME: the following test is not correct; it should account for iperm_c, and pivrow is not - // directly the row pivot. - if (pivrow != jj) m_detPermR = -m_detPermR; - // Prune columns (0:jj-1) using column jj Base::pruneL(jj, m_perm_r.indices(), pivrow, nseg, segrep, repfnz_k, xprune, m_glu);