Fix sparse triangular view iterator
diff --git a/Eigen/src/SparseCore/SparseTriangularView.h b/Eigen/src/SparseCore/SparseTriangularView.h index 5cac825..2e53114 100644 --- a/Eigen/src/SparseCore/SparseTriangularView.h +++ b/Eigen/src/SparseCore/SparseTriangularView.h
@@ -152,8 +152,8 @@ } } -// inline Index row() const { return (ArgType::Flags&RowMajorBit ? Base::outer() : this->index()); } -// inline Index col() const { return (ArgType::Flags&RowMajorBit ? this->index() : Base::outer()); } + inline Index row() const { return (ArgType::Flags&RowMajorBit ? Base::outer() : this->index()); } + inline Index col() const { return (ArgType::Flags&RowMajorBit ? this->index() : Base::outer()); } inline StorageIndex index() const { if(HasUnitDiag && m_returnOne) return internal::convert_index<StorageIndex>(Base::outer());
diff --git a/test/sparse_basic.cpp b/test/sparse_basic.cpp index 9e102b7..298619e 100644 --- a/test/sparse_basic.cpp +++ b/test/sparse_basic.cpp
@@ -746,6 +746,11 @@ // check sparse-triangular to dense refMat3 = m2.template triangularView<StrictlyUpper>(); VERIFY_IS_APPROX(refMat3, DenseMatrix(refMat2.template triangularView<StrictlyUpper>())); + + // check sparse triangular view iteration-based evaluation + m2.setZero(); + VERIFY_IS_CWISE_EQUAL(m2.template triangularView<UnitLower>().toDense(), DenseMatrix::Identity(rows, cols)); + VERIFY_IS_CWISE_EQUAL(m2.template triangularView<UnitUpper>().toDense(), DenseMatrix::Identity(rows, cols)); } // test selfadjointView